Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show serial number when moving to next page #3425

Merged
merged 2 commits into from
May 31, 2021
Merged

Show serial number when moving to next page #3425

merged 2 commits into from
May 31, 2021

Conversation

gautamjajoo
Copy link
Member

Fix: Serial number is visible when moving to next page in All submissions and My Submissions tab

Screenshot from 2021-05-23 15-17-38

@Ram81 @Kajol-Kumari

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021 •
edited
Loading

Codecov Report

Merging #3425 (8ca9f27) into master (96968d6) will decrease coverage by 0.55%.
The diff coverage is 34.50%.

@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
- Coverage   72.93%   72.37%   -0.56%     
==========================================
  Files          83       20      -63     
  Lines        5368     3175    -2193     
==========================================
- Hits         3915     2298    -1617     
+ Misses       1453      877     -576
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 65.04% <33.22%> (-8.66%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 65.04% <33.22%> (-8.66%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309b829...8ca9f27. Read the comment docs.

@Ram81
Copy link
Member

Ram81 commented May 28, 2021

@Kajol-Kumari can you test this PR locally and approve if everything looks good.

Kajol-Kumari
Kajol-Kumari approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise, Serial number is appearing perfectly fine.
Codewise, Looks clean and good to go!

Ram81
Ram81 approved these changes May 30, 2021
View reviewed changes
Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@RishabhJain2018 RishabhJain2018 merged commit f6f9a3f into Cloud-CV:master May 31, 2021
burnerlee pushed a commit to burnerlee/EvalAI that referenced this pull request Jun 14, 2021
@gautamjajoo @RishabhJain2018 @burnerlee
Frontend_V2: Fix S.No in my submissions page(Cloud-CV#3425)
64c9cec 
Co-authored-by: Rishabh Jain <rishabhjain2018@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ram81 Ram81 Ram81 approved these changes

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

Assignees
No one assigned
Labels
can-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gautamjajoo @codecov-commenter @Ram81 @Kajol-Kumari @RishabhJain2018